https://bugzilla.redhat.com/show_bug.cgi?id=2086299



--- Comment #12 from Paul Howarth <[email protected]> ---
(In reply to Maxwell G from comment #11)
> This looks good to me besides the licensing issue.

...

> It seems like there are two copies of the GPLv3. I think we should include
> both of them and then query upstream to remove one instead of doing so
> ourselves. What do you think?

Done.
https://github.com/ansible-collections/community.libvirt/issues/122

I figured out what was going on with the %{ansible_collection_url} on the SRPM
for the EPEL-9 build. The SRPM is normally generated using the minimal
buildroot, which does not contain ansible-packaging and hence a definition of
%{ansible_collection_url}. The macro gets expanded for the Fedora build because
it uses dynamic buildrequires and so the SRPM is regenerated with
ansible-packaging present. The normal way to address this would be to have an
ansible-srpm-macros package that contained the definition of
%{ansible_collection_url} and have redhat-rpm-config (and the equivalent
package for EPEL) require ansible-srpm-macros, which would pull it into the
minimal buildroot for the SRPM build. For now though I worked around it by
using %generate_buildrequires unconditionally. If there's ever a need to
support EPEL prior to 9, that could be done in a different way in the
appropriate branch.

Updated packages:

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/ansible-collection-community-libvirt/trunk/ansible-collection-community-libvirt.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/ansible-collection-community-libvirt/ansible-collection-community-libvirt-1.1.0-3.fc37.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to