https://bugzilla.redhat.com/show_bug.cgi?id=2084529

Maxwell G <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[email protected]



--- Comment #1 from Maxwell G <[email protected]> ---
> %global debug_package %{nil}

- This is redundant for noarch packages.

> Requires: python3-flask
> Requires: python3-gssapi

- The python dependency generator should handle this.

> rm -rf $RPM_BUILD_ROOT

- This is no longer necessary.

> %doc config/gssproxy.conf
> %doc config/systemd-httpd-service.conf
> %doc config/httpd.conf
> %doc config/tmpfiles.conf

- Why don't you shorten this to `%doc config` or better yet install the conf
files to the proper location?

- Is it possible to run the tests? If not, you should at least run
`%py3_check_import flask_mod_auth_gssapi`.

- You might want to consider porting this specfile to use the new
pyproject-rpm-macros, but this isn't a hard requirement.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2084529
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to