https://bugzilla.redhat.com/show_bug.cgi?id=2091296



--- Comment #4 from Vitaly Zaitsev <[email protected]> ---
> %global  fastnetmon_commit       420e7b873253fdc1b52b517d9c28db39bf384427
> Version:           1.2.1

Version tag must include commit information. Check this as an example:

-
https://src.fedoraproject.org/rpms/purple-hangouts/blob/rawhide/f/purple-hangouts.spec#_3
-
https://src.fedoraproject.org/rpms/purple-hangouts/blob/rawhide/f/purple-hangouts.spec#_9

I suggest the following:

%global commit0 420e7b873253fdc1b52b517d9c28db39bf384427
%global shortcommit0 %(c=%{commit0}; echo ${c:0:7})
%global date 20220528

Release: 1.%{date}git%{shortcommit0}%{?dist}

When a new tagged version will be released, you should remove these lines and
use standard releases.

> Summary:           A high performance DoS/DDoS load analyzer built on top of 
> multiple packet capture engines (NetFlow, IPFIX, sFlow, PCAP).

The final dot must be removed.

> %global  fastnetmon_project_name fastnetmon

Not used. Can be removed.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to