https://bugzilla.redhat.com/show_bug.cgi?id=2083243



--- Comment #13 from Ondřej Pohořelský <[email protected]> ---
(In reply to Miro Hrončok from comment #12)
> I believe you forgot to add:
> 
>   %license COPYING

Yes, I completely forgot about this line.

> Source0:      
> %{url}/archive/refs/tags/v%{version}.tar.gz#/%{pypi_name}-%{version}.tar.gz
> 
> Nitpick: This line is not aligned with the rest of the lines, Alo, it could
> be quite simpler:
> 
> Source:         %{url}/archive/v%{version}/%{pypi_name}-%{version}.tar.gz

This looks much nicer. Thanks! I was completely lost with all the URLs GitHub
provides to download tarball.

I hope that this time everything is ok :)

SPEC URL:
https://fedorapeople.org/cgit/opohorel/public_git/python-fastbencode.git/plain/python-fastbencode.spec
SRPM URL:
https://fedorapeople.org/cgit/opohorel/public_git/python-fastbencode.git/plain/python-fastbencode-0.0.9-1.fc37.src.rpm

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=87775582


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2083243
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to