https://bugzilla.redhat.com/show_bug.cgi?id=2089243

José Matos <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED



--- Comment #9 from José Matos <[email protected]> ---
(In reply to kkula from comment #8)
> `fedora-review -b 2089243` is working fine now

You are right, my bad. :-(
Actually the June is Portugal national day and so it is holiday. :-)

The review is almost ready:

There is just one minor point to explore:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies

it says:
Packages SHOULD use the opt-in build-dependency generator if possible.

Could you try to see if this works?
In the sense that you can remove all the BR (leaving of course python3-devel).


BTW as far as I understand pyproject-rpm-macros is also redundant, as
BuildRequires, since:

$ repoquery --requires python3-devel
Last metadata expiration check: 0:19:53 ago on Thu 16 Jun 2022 08:45:02 AM
WEST.
(pyproject-rpm-macros if rpm-build)
(python-rpm-macros >= 3.10-9 if rpm-build)
(python3-rpm-generators if rpm-build)
(python3-rpm-macros >= 3.10-9 if rpm-build)
/usr/bin/pkg-config
/usr/bin/sh
libpython3.10.so.1.0
libpython3.10.so.1.0()(64bit)
python3 = 3.10.4-1.fc36
python3 = 3.10.5-2.fc36
python3-libs(x86-32) = 3.10.4-1.fc36
python3-libs(x86-32) = 3.10.5-2.fc36
python3-libs(x86-64) = 3.10.4-1.fc36
python3-libs(x86-64) = 3.10.5-2.fc36

That means that when you BuildRequire python3-devel is bring as a dependency.

I will look into this tomorrow, again sorry for the delay.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2089243
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to