https://bugzilla.redhat.com/show_bug.cgi?id=2098379
Robert-André Mauchin 🐧 <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ | |needinfo?(benson_muite@emai | |lplus.org) Status|NEW |POST Assignee|[email protected] |[email protected] CC| |[email protected] --- Comment #2 from Robert-André Mauchin 🐧 <[email protected]> --- - Shorten the summary to 80 characters max - 1) Should the test input be in the documentation directory? Indeed, renmove it. 2) Should the readme be in the src directory as well as in the documentation directory? In theory no, %doc should be linked directly to the README in the Go tree, but the macro automatize everything and does not take this case into account. @[email protected] : [?]: %check is present and all tests pass. You should indeed check that in the build.log, and mark X or ! appropriately. Send me your other review par email so I can check them too. - License ok - Latest version packaged - Builds in mock - Check passes - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Please fix the aforementioned issues before import. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2098379 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
