https://bugzilla.redhat.com/show_bug.cgi?id=2116066
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Fabio Valentini <[email protected]> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide x test suite is run and all unit tests pass (tests are disabled to break a dependency loop) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Looks good to me now (you might want to update the bug title to match the new summary in the .spec file). You'll need to re-disable the tests before importing the package to Fedora, this modification seems to have been lost when you re-ran rust2rpm. Just as an FYI, for Rust crates which have disabled test suites to break circular dependencies, we usually just leave the tests disabled permanently. Doing bootstrap builds is usually not worth it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2116066 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
