https://bugzilla.redhat.com/show_bug.cgi?id=2103073
--- Comment #6 from Pavel Raiskup <[email protected]> --- Thank you for the update, and sorry for delay (I was on vacation). (In reply to Maxwell G from comment #5) > This no longer sorts properly. You should remove the previous entries. I fixed the changelog. I started from scratch, it shouldn't be a problem since the package is not in Fedora, yet. > ``` > install -p -m 0644 doc/fugitive-gitlab.txt %{buildroot}%{vimfiles_root}/doc > install -p -m 0644 plugin/gitlab.vim %{buildroot}%{vimfiles_root}/plugin > for filename in api fugitive omnifunc utils; do > install -p -m 0644 autoload/gitlab/$filename.vim > %{buildroot}%{vimfiles_root}/autoload/gitlab > done > ``` > > This seems unnecessarily convoluted. Why don't you just use `cp -rp`to copy > the directories that you need? I prefer this because I have the list of files (and the permissions) fully under control. I can change this, please just state it is really your preference. > > Requires: vim-common > > This should only depend on vim-filesystem. I think you need a proper vim runtime to use vim fugitive plugin, so vim-filesystem wouldn't be enough? OTOH, the package already depends on vim-fugitive (which transitively depends on vim-common). So I'm just removing this dependency. Spec URL: https://download.copr.fedorainfracloud.org/results/praiskup/vim-fugitive-gitlab/epel-9-x86_64/04809628-vim-fugitive-gitlab/vim-fugitive-gitlab.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/praiskup/vim-fugitive-gitlab/epel-9-x86_64/04809628-vim-fugitive-gitlab/vim-fugitive-gitlab-0~20220701gitb73a8e-1.el9.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2103073 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
