https://bugzilla.redhat.com/show_bug.cgi?id=2123954
--- Comment #2 from Sandro <[email protected]> --- Thank you for the review. I revised the spec file: Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/PyMunin3/fedora-rawhide-aarch64/04809614-python-PyMunin3/python-PyMunin3.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/PyMunin3/fedora-rawhide-aarch64/04809614-python-PyMunin3/python-PyMunin3-3.0.1-2.fc38.src.rpm (In reply to Parag AN(पराग) from comment #1) > Issues: > ======= > - Dist tag is present. I've got no clue what that means. > - Fix rpmlint warning summary-ended-with-dot I removed the trailing dot. > - You don't need below lines as you already have "BuildArch: noarch" > # Package does not provide debug info > %global debug_package %{nil} Hmm. Without it my local mock build fails with: > - local definition of using the updated rpmautospec macro is not needed now > as I see python-rpmautospec-0.3.0 is already built for F35+ and EPEL9 > releases. The spec file I linked is from Copr, which expands %{autorelease} and puts that in the spec file. I can upload my original spec file if needed. > - For %check if there are not tests then you can add %pyproject_check_import > to test that installed modules are importable > This is described in > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #pyproject_check_import Thanks. I added the macro and the import check succeeds. > python3-PyMunin3.noarch: W: invalid-license GPL-3.0 I changed it to "GPL-3.0-only" as per https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Now, what's still missing is a fancy README file. ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2123954 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
