https://bugzilla.redhat.com/show_bug.cgi?id=2118906



--- Comment #7 from Artem <[email protected]> ---
(In reply to Benson Muite from comment #5)

a) Why use 0.3 for Release instead of 1? See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

   Fedora maintainers recommend me this when submitting package for review.
Maybe we should document this in Guidelines. Such 0.X version only needed for
review process and final release version should be '1'. This could help with
potential issue for users who used COPR before and they will not receive update
when package goes into official repo.

b) hcxpmktool.c seems to have executable permissions.

   Upstreamed: https://github.com/ZerBea/hcxtools/pull/220

> The README indicates that hcxhashcattool, hcxessidtool, hcxpmkidtool and 
> hcxmactool will be removed when switching to OpenSSL 3.0. Maybe these should 
> not be packaged? 

Agree. Removed deprecated tools.

---

Spec URL:
https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04813039-hcxtools/hcxtools.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04813039-hcxtools/hcxtools-6.2.7-0.4.fc38.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2118906
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to