https://bugzilla.redhat.com/show_bug.cgi?id=2127414



--- Comment #5 from Jonathan Wakely <[email protected]> ---
(In reply to Benson Muite from comment #4)
> Thanks for your changes. Comments:
> 
> a) In the build log, get warnings of the following type:
> warning: Tag 'TCL_SUBST' at line 237 of file 'Doxyfile' has become obsolete.
>          To avoid this warning please remove this line from your
> configuration file or upgrade it using "doxygen -u"
> This seems minor, but maybe problematic in future.

No, obsolete Doxygen tags are just ignored, so I don't think it will ever cause
a problem. But the Doxygen config is quite old so I'll definitely regenerate
it.

> b) The output of the tests is piped into dev/null 
> It may be helpful to have these in the build log, though not strictly
> necessary.

Good idea.

> c) Get the following output in the build log for the tests:
> test_pstreams EXITED WITH STATUS 3
> test_minimum
> Is this expected?

Oh, I didn't notice that. I'll check it.

Maybe it's something that doesn't work in the koji environment.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2127414
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to