https://bugzilla.redhat.com/show_bug.cgi?id=2082886



--- Comment #4 from Otto Liljalaakso <[email protected]> ---
Thank you for the update, now it builds!
I now managed to run fedora-review,
I have only two comments:

> [!]: Package must own all directories that it creates.
>     Note: Directories without known owners: /usr/lib64/nagios/plugins,
>     /usr/lib64/nagios

Either own them in this package, or Require: nagios-common.
Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership
The reference is terribly unclearly written, unfortunately,
but it boils down to
"if some dependency of yours does not own it, you have to own it yourself."

> [ ]: Package is named according to the Package Naming Guidelines.

Inspecting the output of 'dnf -C search nagios-plugin',
it seems to me that the name of this package should be
'nagios-plugins-systemd'.
There is a large set of others that dropp the 'check_' part from the package
name.
(This comment is not release blocking.)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2082886
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to