https://bugzilla.redhat.com/show_bug.cgi?id=2115102



--- Comment #26 from Miro Hrončok <[email protected]> ---
(In reply to Wayne Sun from comment #24)
> (In reply to Miro Hrončok from comment #23)
> > Sorry for the delay, I somehow missed this is back on me now.
> > 
> > 
> > 
> > > So the pylero CLI is not recommended for fedora as it prefer gnureadline 
> > > package (non-fedora release) over native python3 readline package, this 
> > > should not be an issue for packaging, I have removed the 'rm' part.  
> > 
> > I don't know what you mean here, sorry. Does the command not work when
> > executed?
> > 
> 
> It works but it works better when using gnureadline package.

Ack.


> > > I have added the %pyproject_check_import under %check.
> > 
> > Thanks. Why with -t?
> 
> If the Polarion server url is not specified in config some library will
> failed to import, so only specify to import from top.


Every time something like this is necessary it is a really good idea to put a
comment in the spec, so your future self or another future maintainer knows.

  # If the Polarion server URL is not specified in config some libraries will
  # fail to import, so only specify to import the top-level module:
  %pyproject_check_import -t


Is it possible to exclude the failing libraries with -e instead or would the
list be too long?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2115102
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to