Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=669858 --- Comment #5 from Cédric OLIVIER <[email protected]> 2011-01-25 14:00:51 EST --- Thanks a lot for this review. Spec URL: http://cedric.olivier.free.fr/rpms/signpost-core-1.2.1.1-4/signpost-core.spec SRPM URL: http://cedric.olivier.free.fr/rpms/signpost-core-1.2.1.1-4/signpost-core-1.2.1.1-4.fc13.src.rpm [!] Fully versioned dependency in subpackages, if present. I think the javadoc package needs a versioned dep on the subpackage. -> Requirement added in javadoc section. [!] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) -> Comment added in spec file with git command used [!] If package contains pom.xml files install it (including depmaps) even when building with ant I don't see this installed -> There is a pom.xml, but it isn't used. I have created a build.xml from scratch because upstream pom.xml require a recent maven version which is not available in F-13 and EPEL. So I think it not necessary to install an pom.xml which is not usable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
