https://bugzilla.redhat.com/show_bug.cgi?id=2134019
--- Comment #3 from Sandro Mani <[email protected]> --- Many thanks for the review and sorry for the late reply: > - Sources used to build the package match the upstream source, as provided in > the spec URL. > Note: Upstream MD5sum check error, diff is in > /home/jamesjer/2134019-mingw-python-pip/diff.txt > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > It looks like the tarball in the SRPM is from github, but Source0 claims it > is from pypi. Hmm might be that I had a previous source tarball lying around, I've regenerated the SRPM > - Both binary packages have a Requires on /usr/bin/python3.10. Is that > correct, or should they have a Requires on /usr/bin/mingw32-python3 and > /usr/bin/mingw64-python3, respectively? > > The non-executable-script warnings from rpmlint may be related, as those > shebangs are rewritten to point to /usr/bin/python, I believe. Indeed, fixed by dropping the shebang > - The License tag is not correct, as it does not account for the vendored > libraries included in the binary packages. The python-pip package has a big > comment about that, along with a more complex License tag. It has not been > converted to SPDX. Fixed, and converted to SPDX > - In conjunction with that issue, many of the vendored libraries have their > own license files, none of which are installed with %license. I see that > the python-pip package does this as well. I'm not sure that is correct. All license files are now installed. Spec URL: https://smani.fedorapeople.org/review/mingw-python-pip.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-pip-22.2.2-3.fc38.src.rpm %changelog * Sat Oct 15 2022 Sandro Mani <[email protected]> - 22.2.2-3 - Strip shebang from non-exec scripts - Install all license files - Use SPDX license identifiers, list full license breakup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2134019 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
