https://bugzilla.redhat.com/show_bug.cgi?id=2119295

Marc-Andre Lureau <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(manisandro@gmail.
                   |                            |com)



--- Comment #5 from Marc-Andre Lureau <[email protected]> ---
(In reply to Sandro Mani from comment #4)
> Full review below. A couple of issues:
> 
> - glib-compile-schemas apparently not needed anymore

mingw-gtk3 was still using it, dropped

> - Unowned directories: %{mingwXX_datadir}/{icons,metainfo} could be added to
> mingw-filesystem. Potentially also all locales (as the native filesystem
> does). Or the package should own all locale folders it creates.

I dropped those, they are not used by Windows.

> - %{description} is not expanded (build RPMS contain "%{description}" as
> description)

fixed


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2119295
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to