https://bugzilla.redhat.com/show_bug.cgi?id=1992629



--- Comment #5 from Hirotaka Wakabayashi <[email protected]> ---
Hi Jakub, Thanks for your comments! I have fixed the issues. Please check the
following files.

https://hiwkby.fedorapeople.org/python-oslo-middleware.spec
https://hiwkby.fedorapeople.org/python-oslo-middleware-5.0.0-2.fc38.src.rpm
Koji(Success!) https://koji.fedoraproject.org/koji/taskinfo?taskID=93509228

> The %{common_desc2} line needs to be removed, the variable isn't
> defined now. 
I removed the lines.

> And they already use unittest.mock, so I think you can simply remove
> the python3-mock dependencies.
Thanks! I removed the python3-mock dependency.

> The https://bugs.launchpad.net/oslo.middleware is an issue tracker
> URL, which IMHO isn't ideal, I like the https://launchpad.net/oslo
> better. But it isn't a deal breaker for me, use the one you prefer.
I use https://opendev.org/openstack/oslo.middleware because it is the main
website of oslo.middleware.

> This one is easy to fix, please take a look here
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
I added the dependency to python3-oslo-middleware,
python3-oslo-middleware-tests, python-oslo-middleware-lang and
python-oslo-middleware-doc package.

Thanks in advance,
Hirotaka


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1992629
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to