https://bugzilla.redhat.com/show_bug.cgi?id=2138409



--- Comment #1 from Richard W.M. Jones <[email protected]> ---
The package was generated by a trusted maintainer using rust2rpm so I'm
going to do a reduced review.

Upstream: https://github.com/DzenanJupic/concat-idents

The latest version (1.1.3) is packaged.

Fabio has included the license files as separate files, but that's OK
because he has filed a PR upstream to get those included next time:
https://github.com/DzenanJupic/concat-idents/pull/1

The license is correct, matching the upstream package, and is permitted by
Fedora.

Apart from the license thing there are no downstream changes.

The spec file is legible, matches the packaging guidelines, and is
largely generated.

There are some test failures, but the tests are disabled (with a bcond
to enable them) and the reason is documented in the spec file.

The scratch build was successful.

I downloaded and tested the package by building libblkio against
it (see bug 2124697) and that went well.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2138409
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to