https://bugzilla.redhat.com/show_bug.cgi?id=2103007

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires:
     perl(File::Copy) - Makefile.PL:75
     perl(File::Spec) - Makefile.PL:76
     perl(overload) - Type-Tiny-XS-0.025/t/10bool.t:37

$ rpm -qp --requires perl-Type-Tiny-XS-0.025-1.fc38.x86_64.rpm | sort | uniq -c
| grep -v rpmlib
      1 ld-linux-x86-64.so.2()(64bit)
      1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.36()(64bit)
      1 perl(:MODULE_COMPAT_5.36.0)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Type::Tiny::XS)
      1 perl(:VERSION) >= 5.8.5
      1 perl(warnings)
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
Binary requires are Ok.
TODO: Please consider to add run-requires 'perl(Type::Parser)'

$ rpm -qp --provides perl-Type-Tiny-XS-0.025-1.fc38.x86_64.rpm | sort | uniq -c
      1 perl(Type::Tiny::XS) = 0.025
      1 perl-Type-Tiny-XS = 0.025-1.fc38
      1 perl(Type::Tiny::XS::Util) = 0.025
      1 perl-Type-Tiny-XS(x86-64) = 0.025-1.fc38
Binary provides are Ok.

$ rpmlint ./perl-Type-Tiny-XS*
========================= rpmlint session starts
=======================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has
taken 0.9 s =
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item.

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2103007
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to