https://bugzilla.redhat.com/show_bug.cgi?id=2065938



--- Comment #4 from Jakub Kadlčík <[email protected]> ---
Thank you for the changes Jani,


> Summary:      Development files for chibi-scheme
> Requires:     %{name}%{?_isa} = %{version}-%{release}

I see you switched to spaces. Good :-)
You forgot two TABs here ^^


> %post
> # Always generate images when installing (upgrade or not)
> %{_bindir}/chibi-scheme -mchibi.repl -d %{_datadir}/chibi/chibi.img
> %{_bindir}/chibi-scheme -xscheme.red -mchibi.repl -d %{_datadir}/chibi/red.img
> %{_bindir}/chibi-scheme -mchibi.snow.commands -mchibi.snow.interface 
> -mchibi.snow.package -mchibi.snow.utils -d %{_datadir}/chibi/snow.img

We typically try to avoid using scriptlets as much as possible. I am
not familiar with the chibi-scheme project, so I want to ask you - Do
we really need to run these commands on the user machine? Would it be
possible to prepare these .img files at the end of the %build section
and then move them where they should be in the %install section?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2065938
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to