https://bugzilla.redhat.com/show_bug.cgi?id=2142006



--- Comment #5 from Benson Muite <[email protected]> ---
When running Fedora-review

Issues:
=======
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages

would expect libvsg.so to be in a devel package and versioned files libvsg.so.*
to be in the main package.

Also, no debuginfo package is produced

License breakdown is missing in spec file. In particular

Apache License 2.0
------------------
VulkanSceneGraph-VulkanSceneGraph-1.0.0-rc3/include/vsg/vk/vulkan.h

BSD 3-Clause License
--------------------
VulkanSceneGraph-VulkanSceneGraph-1.0.0-rc3/src/vsg/utils/ResourceLimits.cpp
VulkanSceneGraph-VulkanSceneGraph-1.0.0-rc3/src/vsg/utils/ResourceLimits.h
All other files seem to be MIT. Assume vulkan.h is taken from


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2142006
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to