https://bugzilla.redhat.com/show_bug.cgi?id=2141871
--- Comment #4 from Scott K Logan <[email protected]> --- Thanks for the engagement on this review, folks. > Define the description as global variable... Eh, I'll bite. Implemented in the latest revision. > Use Source instead of Source0... This I'm less keen on. I don't believe a change like this provides value alone, and will only cause more changes if an additional source file becomes necessary. Not a hill I'm willing to die on, just a preference. > Is "MIT" a SPDX identifier or the old legacy "Callaway" identifier? It happens to be both. "Modern Style with sublicense"[1]. > Would you consider *not* using %srcname at least in URL... Sure, implemented in the latest revision. I'll make this process change in all of my reviews moving forward. Spec URL: https://cottsay.fedorapeople.org/python-flake8-quotes/python-flake8-quotes.spec SRPM URL: https://cottsay.fedorapeople.org/python-flake8-quotes/python-flake8-quotes-3.3.1-2.fc38.src.rpm [1] https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_with_sublicense -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2141871 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
