https://bugzilla.redhat.com/show_bug.cgi?id=2138487

Jakub Kadlčík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[email protected]



--- Comment #1 from Jakub Kadlčík <[email protected]> ---
Hello Davide,
thank you for the package.

> %global commit 7bcdbe6810c2d69971f1a41be5d38c21a77278c7
> Version:        1.9.0~%{date}git%{shortcommit}

The versioning is confusing because the VERSION file that setup.py
parses, says it's 1.9.0 but the commit you are mentioning suggests,
the version is 2.0 now.


> # remove broken test
> rm xdfile/tests/test_xdfile.py

Can you please add some issue link, or any explanation indicating when
should we stop removing the test?


> [ ]: Macros in Summary, %description expandable at SRPM build time.
>      Note: Macros in: python3-xdfile (description)

That's weird, I don't see any macros in the description


> python3-xdfile.noarch: E: non-executable-script 
> /usr/lib/python3.11/site-packages/xdfile/puz2xd.py 644 /usr/bin/env python3
> python3-xdfile.noarch: E: non-executable-script 
> /usr/lib/python3.11/site-packages/xdfile/ujson2xd.py 644 /usr/bin/env python
> python3-xdfile.noarch: E: non-executable-script 
> /usr/lib/python3.11/site-packages/xdfile/uxml2xd.py 644 /usr/bin/env python3
> python3-xdfile.noarch: E: non-executable-script 
> /usr/lib/python3.11/site-packages/xdfile/xdfile.py 644 /usr/bin/env python3
> python3-xdfile.noarch: E: non-executable-script 
> /usr/lib/python3.11/site-packages/xdfile/xwordinfo2xd.py 644 /usr/bin/env 
> python3

Can you please file an issue or submit a PR fixing this?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2138487
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to