https://bugzilla.redhat.com/show_bug.cgi?id=2150506
--- Comment #3 from Steve Cossette <[email protected]> --- Thank you for your help! (In reply to Miro Hrončok from comment #2) > Could you please use links for the spec and the SRPM that allow direct > download by automation? Thanks. Done: SPEC: https://api.nicehomeservices.com/images/temp/python-pypresence.spec SRPM: https://api.nicehomeservices.com/images/temp/python-pypresence-4.2.1-1.fc37.src.rpm > > Spec sanity: > > > > %global debug_package %{nil} > > This usually indicates the package should be noarch (BuildArch: noarch) > instead. Since this is a pure python package, this is also the case here. Done. > > > License: BSD-3 > > This is not a valid SPDX license identifier. Did you mean BSD-3-Clause? > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Done, I set it as BSD-3-Clause-LBNL as it matches with the license upstream: https://github.com/qwertyquerty/pypresence/blob/master/LICENSE > > > #%package -n python3-pypresence > > This should remain here, the main package (SRPM) should be named > python-pypresence and there should be a subpackage named python3-pypresence. Done, I uncommented it and fixed the spec to use it. > > > %{?python_provide:%python_provide python3-pypresence} > > This is deprecated and not needed. Please remove it. Done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2150506 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
