https://bugzilla.redhat.com/show_bug.cgi?id=2142671



--- Comment #6 from Jonny Heggheim <[email protected]> ---
> You could do something like this: 
> https://principis.fedorapeople.org/lua-cosmo.spec 

I feel that is getting too hackish and harder to maintain.

> ln -s ../../doc/%{name}/cosmo.md LICENSE.md

For me it does not make sense why %buildroot is not used in the %install
section. The doc location is now hard-coded instead of a macro. 
If the user install with --nodocs flag, then the %license link is dangling.

> I noticed you've removed the index.html from %doc, was this by mistake? I 
> believe it's redundant so it should be fine to leave it out.

I had a look and noticed that they were the "same", but after some thinking I
lean towards that it is best to do the same as opensuse:

> %license %{luarocks_treedir}/%{mod_name}/%{rock_version}/doc/cosmo.md
> %docdir %{luarocks_treedir}/%{mod_name}/%{rock_version}/doc

https://build.opensuse.org/package/view_file/devel:languages:lua/lua-cosmo/lua-cosmo.spec?expand=1

Include all files documentation in the doc folder, since upstream have included
it in their repo and published it on luarocks.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2142671
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to