https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Jonny Heggheim <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Jonny Heggheim <[email protected]> ---
Approved!

Please fix %changelog before import:

> lua-ev.x86_64: W: incoherent-version-in-changelog 1.5-1 ['1.5-2.fc38', 
> '1.5-2']



Suggestion, feel free to keep as is:
I think it would be nice to also include the readme in the %doc (duplicated, in
addition to %license). Users wanting to save space can always install with
--nodocs.

I do not think there is a best practice, but we had some discussion in the
review of lua-cosmo bug 2142671#c4


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2143583
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to