https://bugzilla.redhat.com/show_bug.cgi?id=2140323



--- Comment #2 from Vasiliy Glazov <[email protected]> ---
1. Change License: to GPL-3.0-or-later according
https://docs.fedoraproject.org/en-US/legal/allowed-licenses/

2. Latest version is 5.34.

3. It is good to change 
Source:
https://github.com/pikvm/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
to
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

4. µStreamer in Description is typo?

5. Change %setup -q to %autosetup

6. At %build section add first %set_build_flags and remove
CFLAGS='%{?build_cflags}' \ LDFLAGS='%{?build_ldflags}' \

7. Since it is server application may be you can add simple systemd-service
file for running it?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2140323
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to