https://bugzilla.redhat.com/show_bug.cgi?id=2043541

Jakub Kadlčík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Jakub Kadlčík <[email protected]> ---
Hello Martin,
thank you for the package.


> Version: 0.1.0

There is already 0.2.1 on GitHub, can you please update?


> Summary: Tool/library for building module streams locally.

A summary shouldn't end with a period.


> Source0: 
> https://github.com/mcurlej/module-build/archive/%{version}/%{name}-%{version}.tar.gz

You can do

    Source0: %{URL}/archive/%{version}/%{name}-%{version}.tar.gz

to make the line shorter.


> %description
> A library and a cli tool for building module streams. 

Can you please write 2-3 sentences about the package?


> %check
> %pytest

The tests are failing in Mock, can you please take a look?


> Tue Feb 01 2022 Martin Čurlej <[email protected]> - 0.1.0-1

It may be a good idea to go without the special characters


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2043541
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to