https://bugzilla.redhat.com/show_bug.cgi?id=2120119



--- Comment #25 from Neal Gompa <[email protected]> ---
(In reply to Alessandro Astone from comment #24)
> (In reply to Neal Gompa from comment #23)
> > > %{_systemd_util_dir}/system-preset/95-waydroid.preset
> > 
> > Presets are not allowed in any package except fedora-release. You'll need to
> > make a request for fedora-release to include it.
> > 
> > Cf.
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/
> > #_how_to_enable_a_service_by_default
> 
> I'm aware. If you don't mind i'll keep it in the spec until there's no other
> remarks for the purpose of distributing via copr, without having to fork my
> git tree
> 

I cannot approve a package that violates the policy in this manner, so you'll
need to address it soon.

> > > %triggerin -- %{name} < 1.2.1-13
> > > /usr/lib/systemd/systemd-update-helper mark-restart-system-units 
> > > waydroid-container.service || :
> > 
> > What is this about? Also, this will probably never trigger since no package
> > entering Fedora predates this version.
> 
> I had to get creative to restart the service when upgrading from an older
> release that did not include %systemd_postun_with_restart, to avoid an issue
> with having rewritten the whole sepolicy. Since then I've also added
> %systemd_postun_with_restart so yes, this will serve no purpose if you first
> install the package from @fedora


Right.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2120119
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to