https://bugzilla.redhat.com/show_bug.cgi?id=2156091



--- Comment #2 from Vasiliy Glazov <[email protected]> ---
1. Need to change License name to Zlib.

2. Remove %global gittag %{commit} as unused.

3. Change 
Source0:       
https://github.com/SciDAVis/qwtplot3d/archive/%{commit}/qwtplot3d-%{commit}.tar.gz
to
Source0:        %{url}/archive/%{commit}/qwtplot3d-%{commit}.tar.gz

4. It is really necessary?
Requires:       cmake(Qt6Core)
Requires:       cmake(Qt6Gui)

5. Change
%autosetup -n qwtplot3d-%{commit} -N

%patch0 -p1 -b .backup
to
%autosetup -p1 -n qwtplot3d-%{commit} -N


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2156091
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to