https://bugzilla.redhat.com/show_bug.cgi?id=2159144

Tao Jin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Tao Jin <[email protected]> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05206741-kvmd/kvmd.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/tao-j/pikvm/fedora-rawhide-x86_64/05206741-kvmd/kvmd-3.191-1.fc38.src.rpm


There are some points that worth discuss, your opinions are appreciated.

1. The original author builds a package for each possible hardware combination
https://github.com/pikvm/kvmd/blob/1b10766071ad96dcd5e788a8b2fb6e178e44e20c/PKGBUILD#L189
Do we also want this in fedora? Currently the default config files are located
at %{_datadir}

2. The kvmd binary has to read/write /dev/gpiochip* sometimes (it is 660 on my
system). So the kvmd* user has been added to the gpio group. 

3. The upstream has some hardcoded code to access device_tree and vcgencmd,
which may only exists in rpi distribution. So I copied some mock script (fake)
to be used.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2159144
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to