https://bugzilla.redhat.com/show_bug.cgi?id=1901306

Petr Menšík <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([email protected]
                   |                            |e)



--- Comment #9 from Petr Menšík <[email protected]> ---
I have passed the review.

Since the core of tlpi distribution is large collection of code examples, I
think it would make sense to export also BuildArch: noarch subpackage
containing the code as documentation (%doc), perhaps in
%_datadir/%{name}/examples directory. Easy way to install and read those
examples by package manager would be nice I think. It would be possible to
downloading them from srpm, but that is not so user friendly.

I might be at least compiled in %check phase. There are some examples not
compiling on my system, but most of them can be compiled. Would it make sense
to make those examples installable as a package too?

For example installing ./cap/show_secbits binary to
/usr/bin/tlpi-cap-show_secbits executable. Of course those should be in
separate subpackage, because most people would not need them. But since they
are included, why not building them?

I have made useful list with simple command:
make all
find * -type f -executable | while read F; do DN=$(dirname -- "$F");
BN=$(basename -- "$F"); echo install $F %{_bindir}/tlpi-$DN-$BN; done

It might be part of tlpi-examples-bin or something similar. Would that make
sense?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1901306
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to