https://bugzilla.redhat.com/show_bug.cgi?id=2162694

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #16 from Miro Hrončok <[email protected]> ---
Package APPROVED. The following opinionated suggestions are optional:



> BuildRequires: desktop-file-utils

This could use an extra space before desktop-file-utils to align with the
previous BuildRequires in the spec.


> # Main package is BSD-3

Using the actual SPDX tags in the comments makes the License tag easier to
review. BSD-3-Clause in this case.

The whole License block would be a bit easier to read if it started and ended
with an empty line.


> URL:            http://jupyter.org

Suggestion: https://jupyter.org (HTTPS)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2162694
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to