https://bugzilla.redhat.com/show_bug.cgi?id=2151289



--- Comment #12 from Tomi Lähteenmäki <[email protected]> ---
Thanks for the review!

> 1. Why %global debug_package %{nil} ?

No reason, removed it.

> 2. Change

I'm not sure about what you exactly want, could you elaborate?

> 4. Add to %check section:

The appstream-data validation fails so included a patch fixing it and sent the
patch to the upstream.

> 3. Add
> 5. Change %setup -n %{name}-%{version}

Added.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2151289
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to