Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Perl-Critic-Bangs - Collection of handy Perl::Critic policies https://bugzilla.redhat.com/show_bug.cgi?id=673197 Summary: Review Request: perl-Perl-Critic-Bangs - Collection of handy Perl::Critic policies Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: [email protected] ReportedBy: [email protected] QAContact: [email protected] CC: [email protected], [email protected] Estimated Hours: 0.0 Classification: Fedora Spec URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Bangs/perl-Perl-Critic-Bangs.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Perl-Critic-Bangs/perl-Perl-Critic-Bangs-1.06-1.fc15.src.rpm Description: The rules included with the Perl::Critic::Bangs group include: - Commented-out code is usually noise. It should be removed. - Watch for comments like "XXX", "TODO", etc. - Tests should have a plan. - Variables like $user and $user2 are insufficiently distinguished. - Determining the class in a constructor by using "ref($proto) || $proto". - Adding modifiers to a regular expression made up entirely of a variable created with qr() is usually not doing what you expect. - Vague variables like $data or $info are not descriptive enough. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
