https://bugzilla.redhat.com/show_bug.cgi?id=2156932



--- Comment #3 from Benson Muite <[email protected]> ---
Adding bundled provides seems reasonable:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

A diff of the files  SGP4.cpp  SGP4.h in python-sgp4 and from 
http://celestrak.com/publications/AIAA/2006-6753/AIAA-2006-6753.zip
shows they are the same. 

It is possible to create a shared library as described at:
https://renenyffenegger.ch/notes/development/languages/C-C-plus-plus/GCC/create-libraries/index

 gcc -c -fpic SGP4.cpp -o SGP4.o
 gcc -shared SGP4.o -o libSGP4.so

However, a different method is needed to  create bindings to a c library, see
for example:
https://blog.hardinglabs.com/python-ctypes-to-sgp4.html
https://swig.org/tutorial.html

As this would change the package substantially, bundling seems reasonable.
Upstream may consider using SWIG or similar approaches at some point.

Please do check on licensing, and update appropriately


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2156932
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to