https://bugzilla.redhat.com/show_bug.cgi?id=2169246
Neal Gompa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|[email protected] |[email protected] CC| |[email protected] --- Comment #2 from Neal Gompa <[email protected]> --- Spec review: > desktop-file-validate %{buildroot}%{_datadir}/applications/%{app_id}.desktop > appstream-util validate-relax --nonet > %{buildroot}%{_datadir}/appdata/%{app_id}.appdata.xml Nit: These should be in %check so that it's obvious they're part of package verification > %{_datadir}/icons/hicolor/*/*/%{app_id}* This means we need "Requires: hicolor-icon-theme" in the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2169246 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
