https://bugzilla.redhat.com/show_bug.cgi?id=2168255



--- Comment #8 from Ondrej Mosnáček <[email protected]> ---
(In reply to Neal Gompa from comment #6)
> > +%if 0%{?rhel} <= 7
> 
> This will make it get disabled on Fedora too.
> 
> You want "%if 0%{?rhel} && 0%{?rhel} <= 7" instead. Alternatively, if you
> think nobody will build on older stuff, then "%if 0%{?el7}" will work too.

Oh, you're right, the "this is a RHEL that is older than 7" condition can't be
implemented in a single comparison. Indeed %rhel < 7 is not a case we care
about here, but I find using </>/<=/>= better semantically - "Beyond this line
the packages are too old - don't even try to run the tests."


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2168255
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to