https://bugzilla.redhat.com/show_bug.cgi?id=2168858

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Miro Hrončok <[email protected]> ---
(In reply to Karolina Surma from comment #1)
> Starting with question marks as I'm not familiar with arch packages. 
> 
> Fedora Review points out this one: 
> 
> - Header files in -devel subpackage, if present.
>   Note: python3-rapidfuzz : /usr/lib64/python3.11/site-
>   packages/rapidfuzz/rapidfuzz.h
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_devel_packages

Is this file required for the package to function? If not, it should probably
not be installed (that should be fixable upstream). If it is, it needs to stay.

> I don't know how to evaluate those points. 
> 
> C/C++:
> [ ]: Package does not contain kernel modules.

Unlikely. Kernel modules don't live in %{python3_sitearch}.

> [ ]: Package contains no static executables.

Check if the package BRs any static libraris.

> [ ]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.

If the .so file is a Python extension module in %{python3_sitearch}, this check
is not relevant.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2168858
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to