https://bugzilla.redhat.com/show_bug.cgi?id=2168538
--- Comment #5 from Dominik 'Rathann' Mierzejewski <[email protected]> --- (In reply to Benson Muite from comment #4) > Thanks. Fedora review has a number of warnings: > > > minidlna.x86_64: W: post-without-tmpfile-creation > /usr/lib/tmpfiles.d/minidlna.conf Not sure what this means. https://docs.fedoraproject.org/en-US/packaging-guidelines/Tmpfiles.d/ make no mention of %post. > minidlna.x86_64: W: non-standard-uid /etc/minidlna.conf minidlna > minidlna.x86_64: W: non-standard-uid /run/minidlna minidlna > minidlna.x86_64: W: non-standard-uid /var/cache/minidlna minidlna > minidlna.x86_64: W: non-standard-uid /var/log/minidlna minidlna > minidlna.x86_64: W: non-standard-gid /etc/minidlna.conf minidlna > minidlna.x86_64: W: non-standard-gid /run/minidlna minidlna > minidlna.x86_64: W: non-standard-gid /var/cache/minidlna minidlna > minidlna.x86_64: W: non-standard-gid /var/log/minidlna minidlna This is expected, minidlna has it's own user and group. > minidlna.x86_64: E: missing-call-to-setgroups-before-setuid > /usr/sbin/minidlnad This doesn't seem to be an issue in practice, minidlnad is started as minidlna user by the systemd service. It's not intended to be executed by root. But sure, I can probably fix that for correctness sake. > minidlna.x86_64: W: log-files-without-logrotate ['/var/log/minidlna'] minidlna doesn't produce any log files during regular operation with default config. I guess one might add log rotation configuration in case someone enables debug logging. Do any of these affect acceptability of the package in Fedora or can I fix them later? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2168538 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
