https://bugzilla.redhat.com/show_bug.cgi?id=587978

Otto Liljalaakso <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(otto.liljalaakso@ |fedora-review?
                   |iki.fi)                     |needinfo?([email protected])



--- Comment #39 from Otto Liljalaakso <[email protected]> ---
Hello Michal,

yes let us finish this one.

> License:        GPLv2+

Meanwhile, Fedora's system of noting the license has changed.
Now, SPDX identifiers must be used, so this need to be written as
GPL-2.0-or-later.

Reference: https://docs.fedoraproject.org/en-US/legal/license-field/

> Requires:       %{_bindir}/ruby

I asked you to switch to this form, but it turns out I was wrong.
In the context of Requires, this actually must be written as /usr/bin/ruby.
Sorry for the noise.

Reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies,
last paragraph

Other than these two small things, this review is ready.
Please correct them and I will flag the review as complete.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=587978
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to