https://bugzilla.redhat.com/show_bug.cgi?id=2181036



--- Comment #5 from Fabio Valentini <[email protected]> ---
> The README links to the img file, should I flag it as documentation instead 
> of removing it to avoid a broken reference?

That's an option. However, there is zero places where users would actually see
rendered README files for this package, so removing the image wouldn't make a
difference either.

> And similarly, it looks like many of the crates include coverage files.  
> Should they all be patched?

It's certainly nicer if these files aren't included in our packages, but they
aren't harmful.
On the other hand, the upstream projects might even be happy about patches (to
add "exclude" to Cargo.toml) that make downloads of their crates from crates.io
smaller / faster for everyone? :)

Either way, neither the image, nor CODEOWNERS, nor coverage data is "harmful",
but they are also just bloat. You can remove them, but you don't *have* to.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2181036
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to