https://bugzilla.redhat.com/show_bug.cgi?id=2080743



--- Comment #15 from Fabio Valentini <[email protected]> ---
1. You should regenerate the package with the latest rust2rpm (i.e. v24).

This regeneration step is also necessary for every version update (to ensure
that RPM subpackages <-> cargo features are mapped correctly).
This will also drop "ExclusiveArch:  %{rust_arches}", which is no longer
necessary, and has been removed from the Packaging Guidelines.

2. Where is this forgeurl coming from?
> %global forgeurl0 https://github.com/NLnetLabs/domain
> VCS:            git:%{forgeurl0}

You'd need to manually keep this maintained, as it will be dropped by any
subsequent package updates.
Is there a specific reason why you added this?

===

Other than those two points, the package now looks good to me.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2080743
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to