https://bugzilla.redhat.com/show_bug.cgi?id=2184588

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[email protected]



--- Comment #2 from Miro Hrončok <[email protected]> ---
Using %{pypi_source} without a name argument (i.e. providing the value via
%srcname) is deprecated in the new Python guidelines. I strongly suggest not
defining %srcname at all.

The "# Drop deps" could use some more love (e.g. what kind of deps and why).

The second Summary: could be defined via %{summary}.

"%license LICENSE" might be redundant.

Is it possible to run the tests in %check? If not, please document the reason
in a comment.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2184588
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to