https://bugzilla.redhat.com/show_bug.cgi?id=2184588
Felix Wang <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] --- Comment #19 from Felix Wang <[email protected]> --- I see that no assignee at the moment. I take this. You corrected the things that Miro Hrončok said, most of the package seems good to me. As for license issue, I read the documentation again, it said > If the source package includes the text of the license(s) in its own file, > then that file, containing the text of the license(s) for the package must be > included in %license. Since it says 'must be included in %license', so you are right. The additional packaging of license file using %license will be all right, although %pyproject_save_files macro includes the license file. Apologized for my previous misunderstanding，which may give inconvenience to you. But I note that some python-related packages does not use %license (put license under /usr/share/licenses), like python3-pytest, python3-virtualenv. ref: https://packages.fedoraproject.org/pkgs/pytest/python3-pytest/fedora-rawhide.html https://packages.fedoraproject.org/pkgs/python-virtualenv/python3-virtualenv/fedora-rawhide.html Finally, I approved the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2184588 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
