https://bugzilla.redhat.com/show_bug.cgi?id=2187643

Tom "spot" Callaway <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+
           Assignee|[email protected]    |[email protected]
                 CC|                            |[email protected]



--- Comment #1 from Tom "spot" Callaway <[email protected]> ---
Good:

- rpmlint checks return:
  perl-Hash-Ordered-tests.noarch: W: no-documentation

- package meets naming guidelines
- package meets packaging guidelines
- license (Apache-2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (sha256
8dc36cd79155ae37ab8a3de5fd9120ffba9a31e409258c28529ec5251c59747b)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2187643
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to