https://bugzilla.redhat.com/show_bug.cgi?id=2188736



--- Comment #4 from Yaakov Selkowitz <[email protected]> ---
(In reply to Benson Muite from comment #3)
> Comments:
> a) Can python shebang macro
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_interpreter_invocation
> %py3_shebang_fix SCRIPTNAME 
> be used to update the scripts?

Those are non-executable on purpose because they are not actually scripts, they
are modules of the program.  The actual script, convertall.py, already has its
shebang automatically fixed during post-install.

> b) Pypi parity would be nice:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_parity

Not feasible.  This is not a requirement for non-importable Python consumers,
and this package is not compatible/installable with pip etc.

> c) Is it possible to run a smoke test for the non-GUI version to check the 
> code works?

TBH I never noticed the CLI mode, but now that you mention it, yes it is.

> d) Might it be possible to use 
> BuildRequires: python3dist(pyqt5)
> in the spec file?

OK.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2188736
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to