https://bugzilla.redhat.com/show_bug.cgi?id=2183866

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+
                 CC|                            |[email protected]
             Status|NEW                         |POST



--- Comment #1 from Fabio Valentini <[email protected]> ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.8.3 vs v0.9.0)
- license matches upstream specification (BSD-3-Clause) and is acceptable for
Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

There's a lot of images in the "tests" directory, you might want to add
`exclude = ["/tests/"]` to Cargo.toml, similar to how other packages with large
test data handle this.

Note that the latest version is v0.9.0, but if we explicitly need v0.8.* for
updating alacritty, then sticking with v0.8.3 for now is fine.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2183866
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to