https://bugzilla.redhat.com/show_bug.cgi?id=2189633



--- Comment #2 from Neal Gompa <[email protected]> ---
Initial spec review:

> %global forgeurl https://github.com/systemd/mkosi-initrd/
> %global distprefix %nil
> %forgemeta

Please don't use the forge macros, as they are unmaintained and only exist
because Go and Font macros require them:
https://pagure.io/packaging-committee/pull-request/1270

> %global pkgroot /usr/lib/mkosi-initrd

Three things:

1. Why is this in the middle of the spec?
2. Why isn't this "%{_prefix}/lib"?
3. Why is this in /usr/lib and not /usr/libexec?

> /usr/lib/kernel/install.d/50-mkosi-initrd.install

Please use "%{_prefix}/lib"

> %files
> %doc README.md
> %doc docs/fedora.md

License file is missing.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2189633
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to