https://bugzilla.redhat.com/show_bug.cgi?id=2193370

Felix Wang <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]



--- Comment #2 from Felix Wang <[email protected]> ---
> %define summ Minimal, header-only, Modern C++ library for terminal goodies
> Summary: %{summ}

You do not need use %define here, just put the summary words in the Summary
field, and you can use %{summary} later.

> %if 0%{?with_tests}
> BuildRequires: cmake
> BuildRequires: gcc-c++
> BuildRequires: make> 

> BuildRequires: cmake(doctest)
> %endif

The dependencies of gcc, cmake and make should not be included in %if
conditionals here.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2193370
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to